FlexReview Teams - manage code review rules, DX meetup with Kent Beck 4/5

Configure code review response times and set up rules to automate notifications

Mar 25, 2024

FlexReview Teams

Introducing FlexReview Teams - configure code review assignment and customize review reminders. Each FlexReview Team is represented by a unique GitHub Team, and it inherits the configuration from its parent as specified in GitHub.

There are 3 available configurations for each FlexReview Team:

Review assignment: Configure the assignment based on an expert review, on-call rotation, or load balance among team members.
SLO config: Define code review response times for internal and external team reviews. This SLO config also has a max number of modified lines configuration.
Automated rules: Set up automated rules for PRs that are pending action from the reviewer. Notify the reviewer on Slack or automatically reassign the review to someone else on the team.

FlexReview Teams are still in private Beta. If you are interested in using it, email howto@aviator.co.

Code review SLO dashboard

Code review SLO is the suggested time it should take the reviewer to respond to a PR. Note that this is NOT the time it takes for a PR to be approved, but rather just getting a response.

Think of the code review SLO as an agreement between the author and the reviewer for a pull request. With this agreement, the author is incentivized to create PRs that falls within the bounds of the SLO agreement, and reviewers are incentivized to stay on top of the PRs.

As part of FlexReview Teams, the SLO dashboard displays the code review response times, and the longest pending reviews for your team. It splits the review responses for internal and external team reviews.

Optional status check

There are scenarios where a check is only run in certain conditions. In such cases, you may want to validate the check when it runs, but also accept the state when the check is not run at all. Now you can define the acceptable_statuses as success and missing:

merge_rules:
  labels:
    trigger: mq
  preconditions:
    required_checks:
      - name: conditional_build
        acceptable_statuses:
          - success
          - missing

Hangar DX AMA session with Kent Beck

We are excited to host Kent Beck for our next AMA session. We will dive into software development methodologies, test driven development, the role of AI in software development.

Note that we limit the event to a smaller audience to make sure that we can have a meaningful conversation. The attendees are folks working in the developer experience space.

Please register to save your spot. This event is not recorded to encourage open dialogue and exchange.

When: Apr 5, 10am PST | 1pm EST
RSVP: https://forms.gle/V3smQhXx47DRong4A

Bug fixes and improvements

av CLI

Fixed the issue with PR creation after reparenting a branch.
Introduced branch name prefix for automatic branch naming. This can be set in the config:

pullRequest:
    branchNamePrefix: "av/"

MergeQueue

Fix an authorization issue where member roles can change configurations.
Fix a validation issue on the config page.
Handle the botPR correctly in emergency merge.
Remove fallback for validate the latest SHA.
Handle override_required_checks being None.

FlexReview

Take review load into consideration for suggestions.
Do not show suggest button if FR is not active on the PR page.
Exclude non-active collaborators from suggestions.

AttentionSet

Flip the creator's FALLBACK attention if a reviewer gets an attention.

On-prem release

version: 2024.03.20-2

Our latest version of Onprem also supports FlexReview review assignment (not FlexReview teams).

Release notes

Aviator Updates